ESQL: fix handling equality with MV constants properly #137032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it comes to multi-valued constants (literals): they should emit a warning header, a contract set in place in the compute engine Evaluators.
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
Hi @astefan, I've created a changelog YAML for you. |
astefan
commented
Oct 23, 2025
Comment on lines
+125
to
+126
| warning:Line 3:9: evaluation of [x == [true, false]] failed, treating result as null. Only first 20 failures recorded. | ||
| warning:Line 3:9: java.lang.IllegalArgumentException: single-value function encountered multi-value |
There was a problem hiding this comment.
For anything other than text data types these warnings were missing, leading to an inconsistent handling.
luigidellaquila
approved these changes
Oct 23, 2025
bpintea
approved these changes
Oct 24, 2025
astefan
added
auto-merge-without-approval
💚 Backport successful
|
astefan
added a commit
to astefan/elasticsearch
that referenced
this pull request
Oct 24, 2025
Deal with equality (and implicitly the IN operator) properly when it comes to multi-valued constants (literals): they should emit a warning header, a contract set in place in the compute engine Evaluators. Fixes elastic#136998 Fixes elastic#136939
@bpintea I'll explore this as part of a different PR. From a preliminary evaluation, this will be a refactoring type of PR. EsqlBinaryComparisons in general are handled by the fix in this PR, but it should indeed be handled in EsqlBinaryComparisons. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deal with equality (and implicitly the IN operator) properly when it comes to multi-valued constants (literals): they should emit
a warning header, a contract set in place in the compute engine Evaluators.
Fixes #136998
Fixes #136939