Replace indexes with skippers for all TSDB numeric/keyword/ip fields #138092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than only doing this for fields explicitly configured as dimensions, all numeric/keyword/ip fields in TSDB mode are set to default to index=false and enable skippers on doc values.
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
felixbarny
approved these changes
Nov 14, 2025
Member
felixbarny
left a comment
felixbarny
left a comment
There was a problem hiding this comment.
This changes the behavior for indexes created on or after IndexVersions.TIME_SERIES_DIMENSIONS_USE_SKIPPERS but before IndexVersions.TIME_SERIES_DIMENSIONS_USE_SKIPPERS. Non-dimension fields will have some segments with skippers and some segments with terms/points. Just double checking that this doesn't have any unintended consequences. Chances are that the previous version hasn't been rolled out yet anyway outside of testing environments.
Otherwise, LGTM
Member
|
Ha, I think you addressed this in the commit you made in the same minute I submitted the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than only doing this for fields explicitly configured as dimensions, all
numeric/keyword/ip fields in TSDB mode are set to default to index=false and
enable skippers on doc values.