Skip to content

Implement formatted doc values for exponential histograms #138095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 17, 2025
Merged

Implement formatted doc values for exponential histograms #138095

merged 4 commits into from
Nov 17, 2025
+121 −14

Conversation

@JonasKunz
Copy link
Contributor

@JonasKunz JonasKunz commented Nov 14, 2025

Implements FormattedDocValues for the exponential_histogram field type to allow easy iteration in our downsampling implementation.

@elasticsearchmachine elasticsearchmachine added external-contributor Pull request authored by a developer outside the Elasticsearch team v9.3.0 labels Nov 14, 2025
@JonasKunz JonasKunz force-pushed the exp-histo-formatteddocvals branch from f599220 to b48850e Compare November 14, 2025 13:01
elasticsearchmachine and others added 2 commits November 14, 2025 13:09
[CI] Auto commit changes from spotless
3fee7dc
@JonasKunz
Merge remote-tracking branch 'elastic/main' into exp-histo-formattedd…
5975afc 
…ocvals

# Conflicts:
#	x-pack/plugin/mapper-exponential-histogram/src/test/java/org/elasticsearch/xpack/exponentialhistogram/ExponentialHistogramFieldMapperTests.java
@JonasKunz JonasKunz added >non-issue :StorageEngine/Mapping The storage related side of mappings labels Nov 14, 2025
@JonasKunz JonasKunz marked this pull request as ready for review November 14, 2025 13:50
@JonasKunz JonasKunz requested a review from gmarouli November 14, 2025 13:50
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Nov 14, 2025

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@gmarouli gmarouli requested a review from martijnvg November 14, 2025 14:11
@gmarouli
Copy link
Contributor

gmarouli commented Nov 14, 2025

Looks good to me, but because I have very little experience with this I added @martijnvg as a reviewer too. Thank you @JonasKunz

martijnvg
martijnvg approved these changes Nov 17, 2025
View reviewed changes
Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I think this is the most straightforward way to support exponential histogram working in downsampling. But only if it is a dimension, right?

@gmarouli
Copy link
Contributor

gmarouli commented Nov 17, 2025

LGTM 👍

I think this is the most straightforward way to support exponential histogram working in downsampling. But only if it is a dimension, right?

Yes, the idea for merging them would be to use ExponentialHistogramValuesReader. I do not think we can do better than that, right?

@martijnvg
Copy link
Member

martijnvg commented Nov 17, 2025

Yes, the idea for merging them would be to use ExponentialHistogramValuesReader. I do not think we can do better than that, right?

I think it is fine. Maybe we could do better if we directly integrate with numeric doc values, but benchmarking / profiles should suggest that this would be worth it.

@JonasKunz JonasKunz merged commit 3dc59f6 into elastic:main Nov 17, 2025
34 checks passed
@JonasKunz JonasKunz deleted the exp-histo-formatteddocvals branch November 17, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martijnvg martijnvg martijnvg approved these changes

@gmarouli gmarouli Awaiting requested review from gmarouli

Assignees

No one assigned

Labels

external-contributor Pull request authored by a developer outside the Elasticsearch team >non-issue :StorageEngine/Mapping The storage related side of mappings Team:StorageEngine v9.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JonasKunz @elasticsearchmachine @gmarouli @martijnvg