-
Notifications
You must be signed in to change notification settings - Fork 503
[Akamai] - Migrated SIEM data stream from HTTPJSON to CEL input #15713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
packages/akamai/changelog.yml
Outdated
| # newer versions go on top | ||
| - version: "2.29.0" | ||
| changes: | ||
| - description: Migrated siem data stream from Httpjson to CEL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - description: Migrated siem data stream from Httpjson to CEL. | |
| - description: Migrated siem data stream from HTTP JSON to CEL. |
| program: | | ||
| state.with( | ||
| ( | ||
| state.?cursor.?recovery_mode.orValue(false) ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| state.?cursor.?recovery_mode.orValue(false) ? | |
| state.?cursor.recovery_mode.orValue(false) ? |
similar throughout; after a .? operator, all the subsequent accesses are on optional types, so after the first the ? is redundant.
| ( | ||
| "GET\t" + | ||
| string(u.Scheme) + "\t" + | ||
| string(u.Host) + "\t" + | ||
| string(u.Path) + "?" + | ||
| string(u.RawQuery) + | ||
| "\t\t\t" + sig_base | ||
| ).as(to_sign, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use sprintf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
run celfmt on this
| "cursor": { | ||
| ?"last_offset": lines.size() > 0 ? | ||
| lines[lines.size() - 1].decode_json().as(lastEvent, | ||
| has(lastEvent.offset) ? optional.of(lastEvent.offset) : optional.none() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| has(lastEvent.offset) ? optional.of(lastEvent.offset) : optional.none() | |
| lastEvent.?offset |
💚 Build Succeeded
History
cc @ShourieG |
|
@efd6, addressed all the changes |
Type of change
Proposed commit message
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots