Skip to content

Conversation

@efd6
Copy link
Contributor

@efd6 efd6 commented Oct 22, 2025

Proposed commit message

m365_defender: fix construction of file.path fields in the incident data stream

The ECS definition states that the file.path field should include the
file's basename as well as the directory.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 self-assigned this Oct 22, 2025
@efd6 efd6 added Integration:m365_defender Microsoft Defender XDR bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Oct 22, 2025
@efd6 efd6 force-pushed the s6551-m365_defender branch from 0543ae5 to 6d4a668 Compare October 22, 2025 21:08
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Oct 22, 2025

🚀 Benchmarks report

Package m365_defender 👍(2) 💚(1) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
incident 923.36 418.94 -504.42 (-54.63%) 💔

To see the full report comment with /test benchmark fullreport

@efd6 efd6 marked this pull request as ready for review October 22, 2025 21:44
@efd6 efd6 requested a review from a team as a code owner October 22, 2025 21:44
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@efd6 efd6 force-pushed the s6551-m365_defender branch from 6d4a668 to c78a937 Compare October 30, 2025 03:18
@efd6 efd6 requested a review from ShourieG October 30, 2025 03:18
Copy link
Contributor

@ShourieG ShourieG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…ata stream

The ECS definition states that the file.path field should include the
file's basename as well as the directory.
@efd6 efd6 force-pushed the s6551-m365_defender branch from c78a937 to ba9e822 Compare October 30, 2025 07:10
@efd6 efd6 enabled auto-merge (squash) October 30, 2025 07:11
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @efd6

@efd6 efd6 merged commit 44bdab2 into elastic:main Oct 30, 2025
7 checks passed
@elastic-vault-github-plugin-prod

Package m365_defender - 5.1.1 containing this change is available at https://epr.elastic.co/package/m365_defender/5.1.1/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:m365_defender Microsoft Defender XDR Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants