Skip to content

[Qualys GAV] - Added support for configuring cel max_executions parameter #15748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[Qualys GAV] - Added support for configuring cel max_executions parameter #15748

wants to merge 4 commits into from
+17 −1

Conversation

@ShourieG
Copy link
Contributor

@ShourieG ShourieG commented Oct 24, 2025 •
edited
Loading

Type of change

  • Enhancement

Proposed commit message

The maximum page size for pagination is 300, meaning that without being
able to configure the maximum number of executions users would be
limited to 300k assets.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@ShourieG ShourieG self-assigned this Oct 24, 2025
@ShourieG ShourieG requested a review from a team as a code owner October 24, 2025 12:11
@ShourieG ShourieG added enhancement New feature or request Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Integration:qualys_gav Qualys Global AssetView labels Oct 24, 2025
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

efd6
efd6 reviewed Oct 26, 2025
View reviewed changes
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than repeating the title of the change in the body of the commit message, it should either be empty, or preferably an explanation of why it's necessary.

Suggest

The maximum page size for pagination is 300, meaning that without being
able to configure the maximum number of executions users would be
limited to 300k assets.

packages/qualys_gav/data_stream/asset/agent/stream/cel.yml.hbs
resource.timeout: {{http_client_timeout}}
{{/if}}
resource.url: {{url}}
max_executions: {{max_executions}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
max_executions: {{max_executions}}
{{#if max_executions}}
max_executions: {{max_executions}}
{{/if}}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please. This is defensive.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@elastic-vault-github-plugin-prod
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @ShourieG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@efd6 efd6 efd6 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@ShourieG ShourieG

Labels

enhancement New feature or request Integration:qualys_gav Qualys Global AssetView Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[qualys_gav]: Add max_execution field in the configuration

3 participants

@ShourieG @elasticmachine @efd6