Open
Conversation
this removes potential race conditions and makes testing logic easier by removing concurrency from the filter+output pipeline stage
kares
approved these changes
Mar 18, 2020
Contributor
kares
left a comment
kares
left a comment
There was a problem hiding this comment.
👍 as this should get the plugin suites into a green state.
we can worry about changing the possibilities of tuning worker count later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this removes potential race conditions and makes testing logic
easier by removing concurrency from the filter+output pipeline stage