-
Notifications
You must be signed in to change notification settings - Fork 66
[ML] Report the "actual" memory usage of the autodetect process #2846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 15 commits
a7b1ce2
cb957ca
8f73f02
d3a39ae
e2d1bf5
1a9a99a
5ae22cb
fe6f1fa
582430e
9476ede
e29d8f7
475fef1
fc8888c
6945d3f
3b69b72
1bafa8c
efc311b
6be6395
134a494
ed426ac
4c8bf8b
fa9c4fa
014be1c
41c02de
50c535f
1c5c46e
0109cce
01c1e6b
e2d2d17
7904e76
185a0e0
0a6a086
6c97572
40f522a
733b038
62dce12
55875c0
9c67353
d265102
2cf5752
3ace6f4
4014a72
e3d2f8a
7b39899
58fafb4
033adef
fe71d2a
e8c00e7
13fa5cf
bbe25b1
3ab09ba
39b4f3b
a536d46
0a6e2b1
befb881
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,6 +25,8 @@ const std::string JOB_ID{"job_id"}; | |
const std::string MODEL_SIZE_STATS{"model_size_stats"}; | ||
const std::string MODEL_BYTES{"model_bytes"}; | ||
const std::string PEAK_MODEL_BYTES{"peak_model_bytes"}; | ||
const std::string SYSTEM_MEMORY_BYTES{"system_memory_bytes"}; | ||
const std::string MAX_SYSTEM_MEMORY_BYTES{"max_system_memory_bytes"}; | ||
Comment on lines
+28
to
+29
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. AFAICS, this keys are not used anymore. |
||
const std::string MODEL_BYTES_EXCEEDED{"model_bytes_exceeded"}; | ||
const std::string MODEL_BYTES_MEMORY_LIMIT{"model_bytes_memory_limit"}; | ||
const std::string TOTAL_BY_FIELD_COUNT{"total_by_field_count"}; | ||
|
@@ -60,6 +62,12 @@ void CModelSizeStatsJsonWriter::write(const std::string& jobId, | |
writer.onKey(PEAK_MODEL_BYTES); | ||
writer.onUint64(results.s_AdjustedPeakUsage); | ||
|
||
writer.onKey(SYSTEM_MEMORY_BYTES); | ||
writer.onUint64(results.s_SystemMemoryUsage); | ||
|
||
writer.onKey(MAX_SYSTEM_MEMORY_BYTES); | ||
writer.onUint64(results.s_MaxSystemMemoryUsage); | ||
|
||
writer.onKey(MODEL_BYTES_EXCEEDED); | ||
writer.onUint64(results.s_BytesExceeded); | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,6 +11,7 @@ | |
#include <core/CProcessStats.h> | ||
|
||
#include <core/CLogger.h> | ||
#include <core/CProgramCounters.h> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this include used here? |
||
#include <core/CStringUtils.h> | ||
|
||
#include <errno.h> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,9 +8,11 @@ | |
* compliance with the Elastic License 2.0 and the foregoing additional | ||
* limitation. | ||
*/ | ||
#include <core/CLogger.h> | ||
#include <core/CProcessStats.h> | ||
|
||
#include <core/CLogger.h> | ||
#include <core/CProgramCounters.h> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are these included needed here? |
||
|
||
#include <errno.h> | ||
#include <fcntl.h> | ||
#include <sys/resource.h> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to move it to 9.2.0 now