Skip to content

Make field optional since if aggregation is doc_count it's should not… #1277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make field optional since if aggregation is doc_count it's should not… #1277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de1943d
Make field optional since if aggregation is doc_count it's should not…
wasfree Sep 4, 2025
c09def5
Merge branch 'main' into bugfix/fix-metric-custom-indicator-doc-count
wasfree Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions docs/resources/kibana_slo.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,13 +399,13 @@ Required:

Required:

- `aggregation` (String)
- `field` (String)
- `name` (String)
- `aggregation` (String) The aggregation type for this metric. One of: sum, doc_count. Determines which other fields are required:
- `name` (String) The unique name for this metric. Used as a variable in the equation field.

Optional:

- `filter` (String)
- `field` (String) Field to aggregate. Must NOT be set for doc_count.
- `filter` (String) Optional KQL filter for this metric.



Expand All @@ -422,13 +422,13 @@ Required:

Required:

- `aggregation` (String)
- `field` (String)
- `name` (String)
- `aggregation` (String) The aggregation type for this metric. One of: sum, doc_count. Determines which other fields are required:
- `name` (String) The unique name for this metric. Used as a variable in the equation field.

Optional:

- `filter` (String)
- `field` (String) Field to aggregate. Must NOT be set for doc_count.
- `filter` (String) Optional KQL filter for this metric.



Expand Down
Loading