Skip to content

Conversation

orangecola
Copy link

Fixes #1310

This is my first PR, so please let me know if there’s anything I can improve.

  • policy_id moved to optional, deprecated
  • added policy_ids field
  • Added unit tests
  • Updated kibana API

Some hacking has happened on populateFromAPI and toAPIModel as the kibana API behaves a bit differently with its relation to policy_id and policy_ids.

  • If policy_id is not set, and policy_ids is, it will set policy_id to the first value within policy_id.

Copy link

cla-checker-service bot commented Sep 16, 2025

💚 CLA has been signed

@orangecola
Copy link
Author

I signed the CLA, but it's not updating for some reason

@tobio
Copy link
Member

tobio commented Sep 16, 2025

@orangecola thanks for the PR. It looks like the email address used to author the commits isn't attached to your GitHub profile which is causing the CLA check to fail.

You could either add that email to your profile, or re-author those commits with an email already linked to your profile.

Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a look at this, there's a couple of schema changes we can make to make things a little simpler for users.

@orangecola orangecola requested a review from tobio September 24, 2025 03:35
Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Are you able to add an entry to CHANGELOG.md for this PR?

@orangecola orangecola requested a review from tobio September 25, 2025 06:36
@orangecola
Copy link
Author

I removed the the validations for:

  • size requirements for policy_ids because upgraded versions will show an empty policy with a
  • conflict requirements between policy_id and policy_ids because it will cause imports to fail for old versions.

@tobio
Copy link
Member

tobio commented Sep 28, 2025

size requirements for policy_ids because upgraded versions will show an empty policy with a
conflict requirements between policy_id and policy_ids because it will cause imports to fail for old versions.

@orangecola are you able to provide some steps to reproduce these errors?

@orangecola
Copy link
Author

orangecola commented Sep 29, 2025

@tobio I couldn't reproduce the validation conflicts, for some reason, so i'll revert back to the LGTM commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] policy_ids in elasticstack_fleet_integration_policy
2 participants