-
Notifications
You must be signed in to change notification settings - Fork 119
update integration_policy to include agent_policy_ids #1311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
💚 CLA has been signed |
I signed the CLA, but it's not updating for some reason |
@orangecola thanks for the PR. It looks like the email address used to author the commits isn't attached to your GitHub profile which is causing the CLA check to fail. You could either add that email to your profile, or re-author those commits with an email already linked to your profile. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking a look at this, there's a couple of schema changes we can make to make things a little simpler for users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Are you able to add an entry to CHANGELOG.md
for this PR?
I removed the the validations for:
|
@orangecola are you able to provide some steps to reproduce these errors? |
@tobio I couldn't reproduce the validation conflicts, for some reason, so i'll revert back to the LGTM commit. |
af84ea9
to
0849f75
Compare
Fixes #1310
This is my first PR, so please let me know if there’s anything I can improve.
Some hacking has happened on populateFromAPI and toAPIModel as the kibana API behaves a bit differently with its relation to policy_id and policy_ids.