Fix listing of file names with special characters to avoid crash and unrecognised names #204 #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unrecognised names #204 Tweak the file listing to fix two issues found to affect files with problematic names like `"Terrible file""")))(((][][].secret`. This change may undo performance improvements achieved in #193. - Ensure the `git check-attr filter` command does not quote file name characters by using `-z` arg and some extra trickery to keep space and newline delimiter characters for filter metadata and each file name respectively. This fixes a file named `"Terrible file""")))(((][][].secret` being listed as just `Terrible file`. - Adjust checking for `filter` and `crypt` strings to work with changed output from `check-attr` command. - Tweak `eval 'echo $filename'` portion of command to avoid script crash on files with special characters with error message like `eval: line 192: syntax error near unexpected token`
confirmed 😢 |
|
What exactly is the problem? I must be blind, but I've just created a Do you actually get |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweak the file listing to fix two issues found to affect files with problematic names like
"Terrible file""")))(((][][].secret.This change may undo performance improvements achieved in #193.
Ensure the
git check-attr filtercommand does not quote file name characters by using-zarg and some extra trickery to keep space and newline delimiter characters for filter metadata and each file name respectively.This fixes a file named
"Terrible file""")))(((][][].secretbeing listed as justTerrible file.Adjust checking for
filterandcryptstrings to work with changed output fromcheck-attrcommand.Tweak
eval 'echo $filename'portion of command to avoid script crash on files with special characters with error message likeeval: line 192: syntax error near unexpected token