Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove password from state inspection #1722

Conversation

magnetised
Copy link
Contributor

Fixes #1718

@alco
Copy link
Member

alco commented Oct 1, 2024

@magnetised I have a different take on the same issue - #1772. IMO, it's better to keep the password obfuscated in memory, makes it more resilient to future code changes where we rename the connection manager module or move the connection logic into a different one. It also works in cases where the Inspect protocol is not used to print the process state, such as the case with :io.format('~p', [...]), for example.

@alco alco closed this Oct 14, 2024
@alco alco deleted the 1718-connectionmanager-stores-password-in-clear-text-in-its-state branch October 14, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConnectionManager stores password in clear text in its state
2 participants