fix(mac): Pass buildOptions down to notarization for platform-speci…

…fic build options (#7886)
electron-userland · Nov 19, 2023 · d7e39f0 · d7e39f0
1 parent abf52ea
commit d7e39f0
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/.changeset/popular-countries-type.md b/.changeset/popular-countries-type.md
@@ -0,0 +1,5 @@
+---
+"app-builder-lib": patch
+---
+
+fix(mac): pass in correct notarize options
diff --git a/packages/app-builder-lib/src/macPackager.ts b/packages/app-builder-lib/src/macPackager.ts
@@ -332,7 +332,7 @@ export default class MacPackager extends PlatformPackager<MacConfiguration> {
     }
 
     if (!isMas) {
-      await this.notarizeIfProvided(appPath)
+      await this.notarizeIfProvided(appPath, options)
     }
     return true
   }
@@ -481,10 +481,10 @@ export default class MacPackager extends PlatformPackager<MacConfiguration> {
     return true
   }
 
-  private async notarizeIfProvided(appPath: string) {
-    const notarizeOptions = this.platformSpecificBuildOptions.notarize
-    if (notarizeOptions === false) {
-      log.info({ reason: "`notarizeOptions` is explicitly set to false" }, "skipped macOS notarization")
+  private async notarizeIfProvided(appPath: string, buildOptions: MacConfiguration) {
+    const notarizeOptions = buildOptions.notarize
+    if (!notarizeOptions) {
+      log.info({ reason: "`notarize` options were not provided" }, "skipped macOS notarization")
       return
     }
     const options = this.getNotarizeOptions(appPath)