Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): migrating to typedoc and upgrading mkdocs+material packages #8491

Merged
merged 6 commits into from
Sep 17, 2024

Conversation

mmaietta
Copy link
Collaborator

@mmaietta mmaietta commented Sep 17, 2024

Huge lift to get the documentation site in a much better state.

Upgrading mkdoc and related theme packages. Migrated to typedoc for a variety of reasons, most notably that it can provide more info of properties when rendered (such as @deprecated messages)

Migrates docs dir to pages as template documents. We copy this over to docs before generating .md with typedoc into docs dir. This is all automatically handled when we run pnpm docs:all (if local) or sh ./netlify-docs.sh (if netlify)

Dynamically inserts .md files via {% includes <path> %} tags to streamline maintaining parity with released state of typedoc.

Adjusts CSS to allow full width of browser window to be used (better readability of docs)

Copy link

changeset-bot bot commented Sep 17, 2024

🦋 Changeset detected

Latest commit: 557188f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
app-builder-lib Patch
builder-util Patch
builder-util-runtime Patch
dmg-builder Patch
electron-builder Patch
electron-builder-squirrel-windows Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-snap Patch
electron-publish Patch
electron-updater Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 557188f
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/66e9edb8ac0c0200086fd671
😎 Deploy Preview https://deploy-preview-8491--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

update relative links to new folder `pages` structure
add additional readme intro
fixing links
additional mkdocs plugins
fix sponsor images
add changeset
update docs with embedded interfaces
update schema with proper markdown file links
update snapshot
@mmaietta mmaietta marked this pull request as ready for review September 17, 2024 19:27
@mmaietta mmaietta merged commit 178a3c4 into master Sep 17, 2024
15 checks passed
@mmaietta mmaietta deleted the typedoc-implementation branch September 17, 2024 21:12
@github-actions github-actions bot mentioned this pull request Sep 17, 2024
xyloflake pushed a commit to xyloflake/electron-builder that referenced this pull request Oct 2, 2024
… packages (electron-userland#8491)

Huge lift to get the documentation site in a much better state.

Upgrading `mkdoc` and related theme packages. Migrated to `typedoc` for
a variety of reasons, most notably that it can provide more info of
properties when rendered (such as `@deprecated` messages)

Migrates `docs` dir to `pages` as template documents. We copy this over
to `docs` before generating `.md` with typedoc into `docs` dir. This is
all automatically handled when we run `pnpm docs:all` (if local) or `sh
./netlify-docs.sh` (if netlify)

Dynamically inserts `.md` files via `{% includes <path> %}` tags to
streamline maintaining parity with released state of typedoc.

Adjusts CSS to allow full width of browser window to be used (better
readability of docs)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant