Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove support for node 10 #195

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat!: remove support for node 10 #195

wants to merge 3 commits into from

Conversation

fcastilloec
Copy link
Collaborator

@fcastilloec fcastilloec commented May 5, 2021

This will close #193, close #194, and close #197

@fcastilloec fcastilloec requested a review from malept May 5, 2021 03:46
Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer not to change the minimum Node version supported just for the sake of changing it, even if Node 10 is EOL.

@fcastilloec
Copy link
Collaborator Author

The reason why I decided to submit this was the bump in some of our dependencies which now require node 12+. We don't have to update our dependencies, but I thought it'll be good to keep updating them since there are usually bug/vulnerability fixes when there's a new release. Right now #193 and #194 are blocked because of this.

@fcastilloec
Copy link
Collaborator Author

Also, this problem is happening in all electron-installer- modules too, we won't be able to keep updating some of our dependencies because of them dropping support for node 10.
I think it's a good idea to drop support for EOL version of nodejs. If people need to use any of the tools with older versions of nodejs, they can install an older version of the tool.

@malept what is your suggestion for keeping dependencies updated and not dropping support for node 10?

@malept
Copy link
Member

malept commented May 11, 2021

Here is an example of what I would prefer to see: malept/flatpak-bundler#33

Eventually I'd like to have some sort of semantic-release on these installer packages, so having multiple PRs which trigger multiple releases is not ideal.

@fcastilloec
Copy link
Collaborator Author

@malept I see what you mean, you want to combine the bumping of version and removing of node 10 support into a single PR. I was just thinking of keeping them separate just to keep a cleaner commit log but it makes total sense.
I'll bump the version numbers of the deps here too.

@fcastilloec fcastilloec requested a review from malept May 11, 2021 23:44
@malept
Copy link
Member

malept commented May 11, 2021

I am all for keeping the commits in the branch separate (makes reading the PR easier) but I'm less concerned about the commits in the default branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants