Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Fiddle snap package #1348

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

feat: add Fiddle snap package #1348

wants to merge 15 commits into from
+60 −4

Conversation

VerteDinde
Copy link
Member

@VerteDinde VerteDinde commented May 2, 2023 •
edited
Loading

This PR adds a Fiddle snap distributable and tests out our CI setup for snap development.

The current snap binary can be installed by running sudo snap install --dangerous <binary-name>. If we want to upload the build to the official Snap store, we'll have to create an account and vet the binary there. Minus Snap store submission, this PR should be ready for review.

Improvement list:

  • Icon behaves differently than .deb and .rpm. Update this in the Forge docs
  • "config.features" doesn't contain some of the common plug options by default (i.e. camera, etc). Add them to the installer
  • It looks like the "debug" var also auto-adds the "--destructive-mode" flag on snap - remove that and allow end users to pass in command line flags
  • The snap binary is huge (250MB?!). Enable LZO compression by default in the upstream installer, which should knock down that binary size

@VerteDinde VerteDinde force-pushed the add-snap-package branch 2 times, most recently from f489038 to 9ec848d Compare May 2, 2023 03:28
@VerteDinde VerteDinde force-pushed the add-snap-package branch 2 times, most recently from 1f2dded to 7cd43bc Compare May 2, 2023 04:32
@VerteDinde VerteDinde marked this pull request as ready for review May 2, 2023 21:17
@VerteDinde VerteDinde requested review from a team and codebytere as code owners May 2, 2023 21:17
codebytere
codebytere approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks generally good to me! A few comments but they're non-blocking.

@dsanders11 dsanders11 marked this pull request as draft November 7, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@dsanders11 dsanders11 dsanders11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VerteDinde @codebytere @dsanders11