Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of experimental decorators #1691

Closed
wants to merge 1 commit into from

Conversation

bobbysharma05
Copy link

Refactor Bisector Class to Use TypeScript Experimental Decorators

This PR improves the Bisector class by refactoring method bindings using the @autoBind decorator from core-decorators. This removes manual .bind(this) calls in the constructor, leading to cleaner and more maintainable code.

  • Removed explicit .bind(this) calls in the constructor.
  • Used the @autoBind decorator to automatically bind methods to the instance.
  • Ensured the calculatePivot method is called within the constructor for correct initialization.

image

@bobbysharma05 bobbysharma05 requested review from codebytere and a team as code owners March 10, 2025 17:46
@erickzhao
Copy link
Member

Hi @bobbysharma05,

This PR doesn't meet our quality bar and seems to be entirely AI-generated. While Electron appreciates and encourages community contributions, its maintainers only have limited bandwidth. AI-generated PRs will not be reviewed and will be closed as invalid.

This PR will now be closed. In the future, raising more PRs with purely AI generated content will result in a organization level ban. Please read our GSoC 2025 contributor guidance, specifically the section on "Project Contributions" and subsection 4.

@erickzhao erickzhao closed this Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants