Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Better UX for expired PAT for Gist publishing ISSUE #1549 #1693

Closed
wants to merge 1 commit into from

Conversation

jayzalani
Copy link

Added setWarningDialogToSetting to Implement Navigation for the Settings Button in Warning Dialog

Description:
This PR addresses [ISSUE #1549] by introducing a new function, setWarningDialogToSetting, which enhances the warning dialog by adding navigation to the Settings button.

Changes Implemented:

  1. Added setWarningDialogToSetting function to handle the navigation logic.
  2. Retained the existing showWarningDialog, ensuring backward compatibility.
  3. Implemented unit tests to validate the new functionality.
  4. Provided a video demonstration showcasing the functionality in action.

Why This Change?
The previous implementation (showWarningDialog) did not support navigating to the settings page when users encountered a warning. Instead of modifying/removing it (to avoid breaking existing functionality), I introduced a new function to handle this scenario efficiently.

Demo:
https://github.com/user-attachments/assets/6b66fefc-dad6-4729-b04e-58ef410671e8

I think these would greatly help Improving users Experience as user not have to waste 30-40minutes figuring out what went wrong when PAT expires I also wrote small message for user in Dialogue box "Your GitHub Tokens might have expired!" making him go and check the settings page 😊

@jayzalani jayzalani requested review from codebytere and a team as code owners March 13, 2025 07:28
@jayzalani jayzalani changed the title Better UX for expired PAT for Gist publishing ISSUE #1549 fix: Better UX for expired PAT for Gist publishing ISSUE #1549 Mar 13, 2025
@codebytere
Copy link
Member

Hey @jayzalani, while we appreciate you trying to contribute, the quality of this PR doesn't meet our standards for a few reasons, including:

  • Changing code with no clear benefit
  • Arbitrary unrelated additions to package lock.

Based on these oddities and a few other quirks, we suspect this PR of being entirely AI-generated. While Electron appreciates and encourages community contributions, its maintainers only have limited bandwidth. AI-generated PRs will not be reviewed and will be closed as invalid.

This PR will now be closed. In the future, raising more PRs with purely AI generated content will result in a organization level ban. Please read our GSoC 2025 contributor guidance, specifically the section on "Project Contributions" and subsection 4.

@codebytere codebytere closed this Mar 13, 2025
@jayzalani
Copy link
Author

ok no problem I will keep in mind and will contribute as per rules @codebytere 😊

@jayzalani jayzalani deleted the fix/ui-github-pat branch March 15, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants