Skip to content

ci: avoid installing node-gyp manually #3898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

ci: avoid installing node-gyp manually #3898

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,9 @@ jobs:
name: Windows Setup
shell: bash
command: |
pip install setuptools
cd 'C:\Program Files\nodejs\node_modules\npm\node_modules\@npmcli\run-script'
npm install [email protected]
npm uninstall node-gyp
npm install @electron/[email protected]
- when:
condition:
equal: [node/linux, << parameters.executor >>]
Expand Down Expand Up @@ -136,11 +136,11 @@ jobs:
name: Windows Setup
shell: bash
command: |
pip install setuptools
choco install --no-progress -y wixtoolset --version=3.14.0
echo 'export PATH=$PATH:"/C/Program Files (x86)/WiX Toolset v3.14/bin"' >> "$BASH_ENV"
cd 'C:\Program Files\nodejs\node_modules\npm\node_modules\@npmcli\run-script'
npm install [email protected]
npm uninstall node-gyp
npm install @electron/[email protected]
- when:
condition:
equal: [linux-medium-plus, << parameters.executor >>]
Expand Down