Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI is deprecated, module no longer auto-publishes #105

Closed
VerteDinde opened this issue Aug 31, 2021 · 14 comments · Fixed by #107
Closed

CI is deprecated, module no longer auto-publishes #105

VerteDinde opened this issue Aug 31, 2021 · 14 comments · Fixed by #107
Assignees

Comments

@VerteDinde
Copy link
Member

Hey folks! Sorry, but it looks like the auto-publish for this module is no longer working due to travis-ci.org being deprecated. I think someone with admin privileges needs to migrate the jobs over to travis-ci.com or another CI alternative in order for the jobs to continue.

Are there plans to continue to support the existing CI jobs, or should others work around this in the short-term? Thanks!

@lgeiger
Copy link
Contributor

lgeiger commented Aug 31, 2021

Thanks for investigating! I briefly tried to migrate to travis-ci.com, but it doesn't seem to let me trigger any builds.

I am currently not really involved with the package anymore (huge thanks to @MarshallOfSound and all the contributors for keeping it alive ❤️ ). I'd guess switching to GitHub actions is probably the best solution in the long run since it's already used in one workflow. @MarshallOfSound what do you think?

Let me know if you need any help, I might be able to take a look at this tomorrow.

@MarshallOfSound
Copy link
Member

@lgeiger if you're ok with it the electron team is happy to take ownership of this package in the electron org and configure our CI for it?

We're currently in an awkward state were basically the entire electron ecosystem rests on this one package updating correctly so we'd love to take responsibility for that.

I can't even configure CI here currently because I believe it needs admin permissions to add CI secrets.

@MarshallOfSound
Copy link
Member

If you're OK with the above @lgeiger I think you should be able to initiate a transfer to the electron org, if not I think you have to add me or @VerteDinde as an admin of this repo and we can do the transfer 😄

@lgeiger
Copy link
Contributor

lgeiger commented Aug 31, 2021

Sorry for blocking you! That sounds great. I am not at my laptop at the moment but we can get this transfer done tomorrow when I am back.
@MarshallOfSound You should have full access to the npm package, so if this is urgent feel free to make a manual release. Also I thought you are already admin on this repo. But apparently that's not the case, sorry about that.

@MarshallOfSound
Copy link
Member

Hah it's all good, tomorrow works great I managed to trick semantic release into running locally so I just did that to get us moving

@lgeiger
Copy link
Contributor

lgeiger commented Aug 31, 2021

@MarshallOfSound I'm back online earlier than expected. I just tried to transfer the ownership to the electron org, but I don't have permissions to create public repositories there (as expected since I am not a member). Unfortunately as far as I can tell I can also not give you more permissions to this repo since this is a user account and not a proper organisation.
So it looks like this leaves us with two options:

  1. You already have permissions to transfer ownership. In which case feel free to go ahead and move it to the electron org to make our lives easier.
  2. You need to invite me to the electron org with permissions to create new public repos. And I will do the transfer ASAP.

@MarshallOfSound
Copy link
Member

@lgeiger I think you can transfer the repo to me directly, and then I can transfer it into the electron org. I don't have permission to transfer it at the moment and org policy prevents me adding folks to the electron org without a surprising amount of work 😆 (We have SAML / SSO enforced)

@lgeiger
Copy link
Contributor

lgeiger commented Aug 31, 2021

@lgeiger I think you can transfer the repo to me directly, and then I can transfer it into the electron org. I don't have permission to transfer it at the moment and org policy prevents me adding folks to the electron org without a surprising amount of work 😆 (We have SAML / SSO enforced)

OK, I think then you need to first delete your fork before we can do it like this. Since otherwise GitHub will complain that MarshallOfSound/node-abi already exists.

@MarshallOfSound
Copy link
Member

@lgeiger Ah good call, deleted my fork 👍

@lgeiger
Copy link
Contributor

lgeiger commented Sep 1, 2021

Great! Looks like the move worked 🚀

@lgeiger
Copy link
Contributor

lgeiger commented Sep 1, 2021

To resurrect CI, probably the easiest thing would be to move the current auto-release infrastructure to GitHub actions following the docs here. But maybe some infra is already setup on the electron side where integration would be even easier.

@MarshallOfSound
Copy link
Member

Looks like our CFA config has kicked in and automated releases are back up and running again 👍

@MarshallOfSound
Copy link
Member

Thanks for the transfer and assist @lgeiger

@VerteDinde
Copy link
Member Author

Thanks again @lgeiger, we really appreciate it! 😄 And thanks for all of your work on this module over the years!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants