feat!: migrate Travis to CircleCI, upgrade semver to ^7.3.5 #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VerteDinde
force-pushed
the
add-circle-ci
branch
from
f0b7a73 to
fed0520
Compare
There was a problem hiding this comment.
electron/get@5b0a172#diff-e774e90e159e39c0a392fffa584ea8520508a9a0c10468d0bd685800e28a42f5
See above commit for an example of adding CFA to a repo, you need to add the .releaserc file and the continuous-auth dependency.
VerteDinde
commented
Sep 1, 2021
| filters: | ||
| branches: | ||
| only: | ||
| - master |
There was a problem hiding this comment.
Once we have the CI pipeline up and running, it would awesome to port the default branch over to main; I did a quick sweep of the repo and this PR has the only places where "master" is hardcoded 🙂 But we can make sure this is working first!
malept
reviewed
Sep 1, 2021
malept
reviewed
Sep 1, 2021
VerteDinde
changed the title
VerteDinde
changed the title
MarshallOfSound
approved these changes
Sep 1, 2021
MarshallOfSound
pushed a commit
that referenced
this pull request
Sep 1, 2021
* chore: move travis config to circleci config * chore: retrigger build, clean up steps * chore: add additional tests for node versions * chore: add node 12 and 14 * chore: remove unneeded platform tests * chore: add CFA dependencies * chore: updats old deps, remove travis.yml * chore: add yarn.lock * chore: add node >=10 engine BREAKING CHANGE: semver@^7 requires Node 10, so dropping support for Node < 10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #105
This PR removes the previous Travis config and starts the release automation on Electron's CircleCI jobs. It also bumps several older dependencies up to more recent versions. This includes a breaking change to semver@^7, which will require Node 10. Given that Node 10 itself is EOL, we're dropping support for any versions of Node older than 10.
BREAKING CHANGE: semver@^7 requires Node 10, so dropping support for Node < 10