Validate Assignments in Population
#18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electronsandstuff
force-pushed
the
main
branch
from
03b998e to
46d8b3f
Compare
electronsandstuff
force-pushed
the
validate-assignment
branch
from
474bc7d to
1600888
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where evaluation of a problem on an unbatched array of decision variables results in an invalid
Populationobject. The__call__method has been fixed to avoid this issue. Additionally, validation on assignment has now been turned on in thePopulationobject. This would have caused the assignment to throw an error resulting in detection of the issue earlier. Two new tests have been added to the repo which confirm problem evaluation works correctly on unbatched input and also that validation works correctly.