Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the constraint convention of ParetoBench from g(x) >= 0 representing a feasible individual to g(x) <= 0 being feasible. Many popular multi-objective optimization libraries also use this convention and standardizing will help users avoid confusing problems with the sign of their constraints not being correct.
The changes to accommodate this are the following.
_callPopulationwas changed to "<"Population.g_canonicalwas modified to use the g<0 style constraintHistory._from_h5py_groupwas modified to load experiments with file version 1.0.0 as having constraint direction ">". This should ensure compatibility with previously saved files.src/paretobench/utils.pywas updated to use the new constraint definition.