exclude observable properties from inputsType

electrovir · Jul 19, 2023 · 6ec6679 · 6ec6679
1 parent 8b42757
commit 6ec6679
Show file tree

Hide file tree

Showing 5 changed files with 32 additions and 6 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "element-vir",
-    "version": "14.2.0",
+    "version": "14.2.1",
     "keywords": [
         "custom",
         "web",

diff --git a/src/declarative-element/declarative-element.test.ts b/src/declarative-element/declarative-element.test.ts
@@ -13,6 +13,6 @@ describe('StaticDeclarativeElementProperties', () => {
                 any,
                 any
             >['inputsType']
-        >().toEqualTypeOf<Readonly<{hi: number}>>();
+        >().toEqualTypeOf<{hi: number}>();
     });
 });
diff --git a/src/declarative-element/declarative-element.ts b/src/declarative-element/declarative-element.ts
@@ -10,7 +10,6 @@ import {HostClassNamesMap} from './properties/host-classes';
 import {
     AllowObservablePropertySetter,
     FlattenObservablePropertyGetters,
-    FlattenObservablePropertySetters,
     ObservablePropertyHandlerMap,
 } from './properties/observable-property/observable-property-handler';
 import {RenderCallback, RenderParams, UpdateStateCallback} from './render-callback';
@@ -284,7 +283,7 @@ export interface StaticDeclarativeElementProperties<
         >,
         'stateInitStatic' | 'events'
     >;
-    readonly inputsType: Readonly<FlattenObservablePropertySetters<Inputs, Inputs>>;
+    readonly inputsType: Inputs;
     readonly stateType: Readonly<FlattenObservablePropertyGetters<StateInit>>;
     readonly updateStateType: UpdateStateCallback<StateInit>;
     readonly isStrictInstance: (

diff --git a/src/declarative-element/define-element.test.ts b/src/declarative-element/define-element.test.ts
@@ -18,6 +18,33 @@ describe(defineElement.name, () => {
             },
         });
     });
+    it('allows partial inputs', () => {
+        const MyElement = defineElement<{
+            maybeInput?: string;
+            maybeUndefined?: string | undefined;
+        }>()({
+            tagName: `some-tag-${randomString()}`,
+            cleanupCallback({host}) {},
+            // render callback must return something
+            // @ts-expect-error
+            renderCallback() {},
+        });
+
+        MyElement.assign({
+            maybeInput: '',
+            maybeUndefined: undefined,
+        });
+
+        MyElement.assign({
+            maybeUndefined: undefined,
+        });
+
+        MyElement.assign({
+            maybeUndefined: '',
+        });
+
+        MyElement.assign({});
+    });
 
     it('blocks render callbacks that are async', () => {
         defineElement<{}>()({