docs: document the real governor-smu config schema - #51
Open
Weijtmans wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #49.
The Configuration example on the governor page had drifted from what the
smubranch actually ships, which is exactly the confusion in #49: the installedconfig.tomlhad keys and values the example lacked, and the page gave no way to tell which side to trust.What changed:
default-config.tomlfrom the currentsmubranch, with every key annotated, and the page now says plainly: the installed file is the reference, trust it over any guide's example.fix-frequnder[gpu-usage](overlays hwmonfreq1_inputwith the true SMU-read clock, off by default) and[frequency-range](initial operating range at service start; both it and runtime D-Bus range changes are clamped inside the span of the[[safe-points]]curve).sample/adjustare 250/100_000 in the shipped default,[load-target]is 0.65/0.50. This answers the "my values differ from the example" half of the issue: the file was right, the example was old.busctlread of the live range as the authoritative check.Direct answers to the four questions in #49:
fix-freqis real, leave itfalseunless you want the frequency-reporting fix;[frequency-range]is real, it is the startup range clamp; keep your[load-target]values, the example was stale; your[[safe-points]]do not need to match the example, they are your board's curve.mkdocs build --strictpasses.