"Verify this device" redesign #30596
Conversation
uhoreg
added
the
T-Feature
uhoreg
added
T-Enhancement
and removed
T-Feature
uhoreg
force-pushed
the
verify_device_redesign
branch
from
65a2a47 to
758647f
Compare
| color: $authpage-primary-color; | ||
| background-color: $background; | ||
| border-radius: 4px; | ||
| padding: 20px; | ||
| padding: 20px 20px 60px 20px; |
There was a problem hiding this comment.
For some reason that I haven't been able to figure out, it squishes the bottom of the dialog, so I had to add some extra padding here.
|
Related Documentation No published documentation to review for changes on this repository. How did I do? Any feedback? |
|
I started reviewing this but I'm finding it really hard to follow. It's definitely too big to review in one lump, but the commits don't seem to make much sense either. Could you try restructuring it, into smaller commits, with more explanation about what each commit is doing and why? |
|
I've reworked the commits, to break it up into smaller chunks, and addressed the comments. Some of the style changes are still grouped together, but hopefully it's more understandable now. |
| @@ -967,7 +967,6 @@ | |||
| "title": "Recovery Method Removed", | |||
| "warning": "If you didn't remove the recovery method, an attacker may be trying to access your account. Change your account password and set a new recovery method immediately in Settings." | |||
| }, | |||
| "reset_all_button": "Forgotten or lost all recovery methods? <a>Reset all</a>", | |||
There was a problem hiding this comment.
Note to future archaeologists: the reference to this string was removed in an earlier commit in this PR
There was a problem hiding this comment.
Sorry, I tried to keep the string removals in the same commits as where the code stops using it, but I guess I missed this on.
Co-authored-by: Richard van der Hoff <[email protected]>
uhoreg
force-pushed
the
verify_device_redesign
branch
from
0f34b5b to
8212149
Compare
res/css/views/auth/_AuthPage.pcss
Outdated
| &.mx_AuthPage_modal_noBlur { | ||
| box-shadow: none; | ||
| /* Apply a blurred shadow around the modal */ | ||
| &.mx_AuthPage_modal_blur { |
There was a problem hiding this comment.
this name feels too close to the already-existing (and different) mx_AuthPage_modalBlur
That's why I suggested mx_AuthPage_modal_withBlur, but feel free to come up with something else.
There was a problem hiding this comment.
Right. I've changed it to your suggestion
Fixes #29258
Probably easiest to review commit-by-commit
Checklist
public/exportedsymbols have accurate TSDoc documentation.