-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Adds tooltip for compose menu #31122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds tooltip for compose menu #31122
Conversation
src/components/views/rooms/RoomListPanel/RoomListHeaderView.tsx
Outdated
Show resolved
Hide resolved
src/components/views/rooms/RoomListPanel/RoomListHeaderView.tsx
Outdated
Show resolved
Hide resolved
df91fe4 to
c7a26ec
Compare
c7a26ec to
ba90f3a
Compare
|
@byteplow the PR has lint errors, you can run |
kaylendog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from a crypto perspective, since there's no crypto here!
src/components/views/rooms/RoomListPanel/RoomListHeaderView.tsx
Outdated
Show resolved
Hide resolved
src/components/views/rooms/RoomListPanel/RoomListHeaderView.tsx
Outdated
Show resolved
Hide resolved
|
Not sure about the jest test fail. |
robintown
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed the test failure went away on a re-run. Thanks for the improvement, and sorry for my delay in rechecking this!
cdedcc0
Adds tooltip
New conversationto Compose Menu Button In Room List Header.Checklist
public/exportedsymbols have accurate TSDoc documentation.