Skip to content

Conversation

@byteplow
Copy link
Contributor

@byteplow byteplow commented Oct 29, 2025

Adds tooltip New conversation to Compose Menu Button In Room List Header.

Screenshot from 2025-10-29 16-38-04

Checklist

@florianduros
Copy link
Member

@byteplow the PR has lint errors, you can run yarn lint to list them.

Copy link
Contributor

@kaylendog kaylendog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a crypto perspective, since there's no crypto here!

@byteplow
Copy link
Contributor Author

Not sure about the jest test fail. <MatrixChat /> › with an existing session › onAction() › room actions › leave_room › for a room › should do nothing on cancel dose not fail locally. And i see no connection to my change.

Copy link
Member

@robintown robintown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed the test failure went away on a re-run. Thanks for the improvement, and sorry for my delay in rechecking this!

@robintown robintown added this pull request to the merge queue Nov 21, 2025
Merged via the queue into element-hq:develop with commit cdedcc0 Nov 21, 2025
38 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-Enhancement Z-Community-PR Issue is solved by a community member's PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants