Skip to content

Update "Learn more" link #4686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 9, 2025
Merged

Update "Learn more" link #4686

merged 5 commits into from
May 9, 2025

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented May 6, 2025

Content

To be reviewed commit per commit.

  • update link 83038ae
  • other commit: renaming and cleanup.

Motivation and context

Closes #4684

Screenshots / GIFs

Tests

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner May 6, 2025 17:06
@bmarty bmarty requested review from jmartinesp and removed request for a team May 6, 2025 17:06
@bmarty bmarty added the PR-Misc For other changes label May 6, 2025
Copy link
Contributor

github-actions bot commented May 6, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/GEALT1

Copy link

sonarqubecloud bot commented May 6, 2025

Copy link

codecov bot commented May 6, 2025

Codecov Report

Attention: Patch coverage is 91.80328% with 5 lines in your changes missing coverage. Please review.

Project coverage is 80.11%. Comparing base (390337c) to head (686d9a1).
Report is 10 commits behind head on develop.

Files with missing lines Patch % Lines
.../outgoing/DefaultOutgoingVerificationEntryPoint.kt 0.00% 3 Missing ⚠️
...ion/impl/outgoing/OutgoingVerificationPresenter.kt 95.23% 0 Missing and 1 partial ⚠️
...ysession/impl/outgoing/OutgoingVerificationView.kt 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4686   +/-   ##
========================================
  Coverage    80.11%   80.11%           
========================================
  Files         2126     2126           
  Lines        56270    56273    +3     
  Branches      7014     7014           
========================================
+ Hits         45081    45084    +3     
  Misses        8778     8778           
  Partials      2411     2411           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bmarty bmarty merged commit 3391e7c into develop May 9, 2025
39 checks passed
@bmarty bmarty deleted the feature/bma/updateLink branch May 9, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Update the "Learn more" link on "Confirm your identity" screen
3 participants