Switch from Poetry to uv#452
Open
sandhose wants to merge 2 commits intoquenting/modern-tooling/python-3.10from
Open
Switch from Poetry to uv#452sandhose wants to merge 2 commits intoquenting/modern-tooling/python-3.10from
sandhose wants to merge 2 commits intoquenting/modern-tooling/python-3.10from
Conversation
3 tasks
sandhose
force-pushed
the
quenting/modern-tooling/uv
branch
12 times, most recently
from
2aa588c to
b63d6d9
Compare
sandhose
changed the base branch from
main
to
quenting/modern-tooling/python-3.10
sandhose
force-pushed
the
quenting/modern-tooling/uv
branch
from
b63d6d9 to
a094f02
Compare
sandhose
force-pushed
the
quenting/modern-tooling/python-3.10
branch
from
0a6e24f to
8fac562
Compare
sandhose
force-pushed
the
quenting/modern-tooling/uv
branch
from
a094f02 to
a0ed884
Compare
sandhose
force-pushed
the
quenting/modern-tooling/python-3.10
branch
from
8fac562 to
1215718
Compare
sandhose
force-pushed
the
quenting/modern-tooling/uv
branch
2 times, most recently
from
2ca957a to
9823327
Compare
sandhose
force-pushed
the
quenting/modern-tooling/python-3.10
branch
from
1215718 to
2ad3c6f
Compare
sandhose
force-pushed
the
quenting/modern-tooling/uv
branch
from
9823327 to
ea1433a
Compare
Convert pyproject.toml from Poetry to PEP 621 + uv_build backend. Replace poetry.lock with uv.lock. Update CI workflows to use astral-sh/setup-uv. Rewrite Dockerfile as a clean multi-stage uv build. Remove obsolete MANIFEST.in.
sandhose
force-pushed
the
quenting/modern-tooling/python-3.10
branch
from
2ad3c6f to
21c4d93
Compare
sandhose
force-pushed
the
quenting/modern-tooling/uv
branch
from
ea1433a to
585d548
Compare
reivilibre
approved these changes
Apr 7, 2026
Contributor
reivilibre
left a comment
reivilibre
left a comment
There was a problem hiding this comment.
sgtm otherwise, assuming it works and the sdist looks clean & comparable (& installs properly)
| # Instead, we'll just install what a regular `pip install` would from PyPI. | ||
| ARG TEST_ONLY_IGNORE_POETRY_LOCKFILE | ||
| # Don't download Python — use the one from the base image. | ||
| ENV UV_PYTHON_DOWNLOADS=0 |
Contributor
There was a problem hiding this comment.
this is cryptic and doesn't appear as a valid option in the docs https://docs.astral.sh/uv/reference/settings/#python-downloads
suspect never was meant
| touch /sygnal/requirements.txt; \ | ||
| fi | ||
| # Compile bytecode for faster startup in production. | ||
| ENV UV_COMPILE_BYTECODE=1 |
| disallow_untyped_defs = False | ||
|
|
||
| [mypy-sygnal.helper.proxy.proxyagent_twisted] | ||
| ignore_errors = True |
|
|
||
| [testenv] | ||
|
|
||
| # As of twisted 16.4, trial tries to import the tests as a package (previously |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
poetry-coretouv_buildpoetry.lockwithuv.lock, deleteMANIFEST.inghcr.io/astral-sh/uv:python-*base image, upgrade to Debian trixie, addUV_PYTHON_DOWNLOADS=0, usedocker.io/library/pythonfor runtimematrix-org/setup-python-poetrywithastral-sh/setup-uvuv sync --resolution=lowest-directTEST_ONLY_*Docker build args (that was never used and copied over Synapse)Known limitations
mypy.iniaddsignore_errors = Trueforproxyagent_twisted— this papers over type errors from changed dependency versions. Cleaned up in PR Replace Twisted with aiohttp and native asyncio #454 when the file is deleted.tox.inicommands useuv runwhich bypasses tox's own venv. Tox is removed entirely in PR Replace black, isort, and tox with ruff #453.Test plan
uv syncinstalls successfullydocker build -f docker/Dockerfile .succeeds