-
Notifications
You must be signed in to change notification settings - Fork 417
Define delayed event ratelimit category #18019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define delayed event ratelimit category #18019
Conversation
Apply ratelimiting on delayed event management separately from messages.
hughns
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see question inline about the default value.
|
@AndrewFerr what is the current status on this topic? |
I still need to address the review comments, but once that's done, this should be good to go (barring further review). It should also be usable for testing/development until then. Since this ratelimit targets the simpler management commands of cancel/restart/get, it's less complicated than the ratelimits we want for delayed messages themselves, which does require more thought. |
Co-authored-by: Andrew Morgan <[email protected]>
Also change the default values appropriately
anoadragon453
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM!
Complement test failures are a flake. Note that TestDelayedEvents/delayed_state_events_are_kept_on_server_restart has been flakey for a while; could you please fix that in another PR @AndrewFerr :)
This rate limit is for the _management_ of delayed events, not the sending of the events themselves (which will be managed by a different ratelimit setting to be added later).
Head branch was pushed to by a user without write access
Targets config key added by element-hq/synapse#18019
|
This should be ready to merge now. The only change since the review is b014c07. |
The new rate limits are more suitable for running Element Call. Ref: - https://github.com/element-hq/element-call/blob/93ae2aed9841e0b066d515c56bd4c122d2b591b2/docs/self-hosting.md#a-matrix-homeserver - #3562 Instead of trying to increase them conditionally only when Element Call is enabled, it's simpler and good-enough to just increase them in all cases.
Apply ratelimiting on delayed event management separately from messages.
Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.(run the linters)