Skip to content

Prevent duplicate GH releases being created during Synapse release process #19096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2025
Merged

Prevent duplicate GH releases being created during Synapse release process #19096

merged 2 commits into from
Oct 30, 2025
+7 −11

Conversation

@anoadragon453
Copy link
Member

@anoadragon453 anoadragon453 commented Oct 24, 2025 •
edited
Loading

Stop relying on the softprops/action-gh-release action and use the provided gh cli to do so instead.

softprops/action-gh-release seemed to have a bug where it would fail to find the existing, untagged release. It would then create a new release, and we'd end up with two.

gh just works, and is already pre-installed. Let's use that instead.

TODO:

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct (run the linters)

@anoadragon453
Use gh to attach assets to release instead
c168560 
Stop relying on the `softprops/action-gh-release` action and use the
provided `gh` cli to do so instead.

`softprops/action-gh-release` seemed to have a bug where it would fail
to find the existing, untagged release. It would then create a new
release, and we'd end up with two.

`gh` just works, and is already pre-installed. Let's use that instead.
@anoadragon453 anoadragon453 changed the title Use gh to attach assets to release instead Prevent duplicate GH releases being created during Synapse release process Oct 24, 2025
@anoadragon453 anoadragon453 marked this pull request as ready for review October 24, 2025 10:37
@anoadragon453 anoadragon453 requested a review from a team as a code owner October 24, 2025 10:38
@anoadragon453 anoadragon453 mentioned this pull request Oct 24, 2025
Closed
MadLittleMods
MadLittleMods reviewed Oct 28, 2025
View reviewed changes
MadLittleMods
MadLittleMods approved these changes Oct 29, 2025
View reviewed changes
Copy link
Contributor

@MadLittleMods MadLittleMods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works, it works 👍

Nice to get rid of a random GitHub action as well 💪

@anoadragon453 anoadragon453 merged commit f54ddbc into develop Oct 30, 2025
36 checks passed
@anoadragon453 anoadragon453 deleted the anoa/dont_create_duplicate_releases branch October 30, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MadLittleMods MadLittleMods MadLittleMods approved these changes

Assignees

No one assigned

Labels

Z-Release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anoadragon453 @MadLittleMods