Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReceiverDialog: GTK4 prep #30

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ReceiverDialog: GTK4 prep #30

wants to merge 1 commit into from

Conversation

danirabbit
Copy link
Member

  • Rename to ReceiverDialog so its clear what kind of object this is in other classes
  • Bump copyright header
  • Fix minor codestyle issues like whitespace
  • Use child property
  • Don't set image size, just its gicon

@danirabbit danirabbit requested a review from a team February 26, 2025 21:28
jeremypw
jeremypw reviewed Feb 28, 2025
View reviewed changes
Copy link

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good an unlikely to cause regressions but I am unable to test as file receiving does not work with my Android phone on Horus and I am only I am only able to run OS8 in A VM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremypw jeremypw jeremypw left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
GTK4 Porting
Status: Needs Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danirabbit @jeremypw