Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework word completion: Do not reparse whole document unnecessarily #1531

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Feb 1, 2025

This should only be merged after the code that implements dynamic updating of the word list (by detecting insertions and deletions rather than key presses) else the word list may get out of date more often (e.g. if doc changed externally).

The document is fully parsed once on loading, editing the document does not usually require a full reparse (unless forced).

  • Add a flag to the prefix tree to indicate whether the associated document has undergone its initial, complete parse.
  • Move timeout into on_new_sourceview and only call for unparsed documents

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant