Skip to content

PluginsManager: cleanups #1562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danirabbit merged 2 commits into from
May 21, 2025
Merged

PluginsManager: cleanups #1562

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7aef48
PluginsManager: cleanups
danirabbit May 21, 2025
bfe436a
Merge branch 'master' into danirabbit/pluginmanager-cleanups
leonardo-lemos May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 8 additions & 12 deletions src/Services/PluginManager.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,13 +65,6 @@ namespace Scratch.Services {
}

public class PluginsManager : GLib.Object {
Peas.Engine engine;
Peas.ExtensionSet exts;

public Interface plugin_iface { private set; public get; }
public weak MainWindow window {get; construct; }

// Signals
public signal void hook_window (Scratch.MainWindow window);
public signal void hook_share_menu (GLib.MenuModel menu);
public signal void hook_toolbar (Scratch.HeaderBar toolbar);
Expand All @@ -82,10 +75,13 @@ namespace Scratch.Services {
public signal void extension_added (Peas.PluginInfo info);
public signal void extension_removed (Peas.PluginInfo info);

private Peas.Engine engine;

public weak MainWindow window { get; construct; }
public Interface plugin_iface { get; private set; }

public PluginsManager (MainWindow _window) {
Object (
window: _window
);
Object (window: _window);
}

construct {
Expand All @@ -98,7 +94,7 @@ namespace Scratch.Services {
Scratch.settings.bind ("plugins-enabled", engine, "loaded-plugins", SettingsBindFlags.DEFAULT);

/* Our extension set */
exts = new Peas.ExtensionSet.with_properties (
var exts = new Peas.ExtensionSet.with_properties (
engine,
typeof (ActivatablePlugin),
{"object"},
Expand Down Expand Up @@ -143,7 +139,7 @@ namespace Scratch.Services {
});
}

void on_extension_foreach (Peas.ExtensionSet exts, Peas.PluginInfo info, Object ext, void* data) {
private void on_extension_foreach (Peas.ExtensionSet exts, Peas.PluginInfo info, Object ext, void* data) {
((ActivatablePlugin)ext).activate ();
}

Expand Down