Skip to content

Rework terminal settings #1585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lenemter merged 16 commits into from
Aug 10, 2025
Merged

Rework terminal settings #1585

lenemter merged 16 commits into from
Aug 10, 2025
+150 −60

Conversation

@jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Jun 3, 2025 •
edited
Loading

Fixes #1586
Fixes #276

  • Handle absence of pantheon terminal settings schema better
  • Monitor settings for changes, Terminal settings falling back to Gnome settings for "audible-bell"
  • Always monitor default Gnome font setting
  • Always follow Gnome cursor-blink setting
  • Terminal pane does not crash if neither Terminal nor Gnome settings schemas found (may need to be addressed for Code as whole but out of scope for this PR)

The behaviour with regard to Terminal/System style settings is unchanged - this will be addressed in a separate PR.

The Terminal pane only responds to changes in the Terminal "foreground", "background" and "palette" keys but not "window-style" or "cursor-color".

@jeremypw jeremypw added this to the 8.1 milestone Jun 16, 2025
@jeremypw jeremypw marked this pull request as ready for review June 27, 2025 18:50
@jeremypw jeremypw requested a review from a team June 27, 2025 18:52
zeebok
zeebok reviewed Jul 14, 2025
View reviewed changes
@jeremypw
Check for non-null settings in keypress handler.
fd63d44 
* Handle Shift-Control copy-paste anyway
@jeremypw
Copy link
Collaborator Author

jeremypw commented Jul 14, 2025 •
edited
Loading

Now implements Shift-Control modified copy-paste keys in absence of terminal settings (the Vte widget does not so cannot just propagate). This follows Terminal app behaviour.

@jeremypw jeremypw requested a review from zeebok July 14, 2025 12:17
@jeremypw jeremypw mentioned this pull request Jul 18, 2025
Merged
2 tasks
@jeremypw jeremypw modified the milestones: 8.1, 8.2 Jul 23, 2025
lenemter
lenemter requested changes Aug 10, 2025
View reviewed changes
@jeremypw jeremypw requested a review from lenemter August 10, 2025 13:10
@jeremypw
Copy link
Collaborator Author

jeremypw commented Aug 10, 2025

@lenemter Thanks for the review! I have incorporated your suggestions.

lenemter
lenemter approved these changes Aug 10, 2025
View reviewed changes
Copy link
Member

@lenemter lenemter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and works as expected. Good job

@lenemter lenemter merged commit 34ba8fb into master Aug 10, 2025
6 checks passed
@lenemter lenemter deleted the jeremypw/terminal/no-settings-schema branch August 10, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lenemter lenemter lenemter approved these changes

@zeebok zeebok Awaiting requested review from zeebok

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

8.2

Development

Successfully merging this pull request may close these issues.

Relies on external Terminal settings keys Listen for changes to Terminal color scheme

4 participants

@jeremypw @zeebok @lenemter