Skip to content

CloneRepositoryDialog: fix warning attaching null widget #1609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danirabbit merged 2 commits into from
Jun 24, 2025
Merged

CloneRepositoryDialog: fix warning attaching null widget #1609

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
248a0ad
CloneRepositoryDialog: fix warning attaching null widget
danirabbit Jun 24, 2025
615c6f3
Merge branch 'master' into danirabbit/clonerepositorydialog-griderrro
leonardo-lemos Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions src/Dialogs/CloneRepositoryDialog.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ public class Scratch.Dialogs.CloneRepositoryDialog : Granite.MessageDialog {
private Gtk.Button clone_button;
private Gtk.Stack stack;
private Gtk.Spinner spinner;
private Gtk.Revealer revealer;

public bool can_clone { get; private set; default = false; }
public string suggested_local_folder { get; construct; }
Expand Down Expand Up @@ -115,18 +114,18 @@ public class Scratch.Dialogs.CloneRepositoryDialog : Granite.MessageDialog {
};
local_project_name_entry.changed.connect (validate_local_name);

var content_box = new Gtk.Grid ();
content_box.attach (new CloneEntry (_("Repository URL"), remote_repository_uri_entry), 0, 0);
content_box.attach (new CloneEntry (_("Location"), folder_chooser_button), 0, 1);
content_box.attach (new CloneEntry (_("Name of Clone"), local_project_name_entry), 0, 2);
content_box.attach (revealer, 1, 2);
var content_box = new Gtk.Box (VERTICAL, 0);
content_box.add (new CloneEntry (_("Repository URL"), remote_repository_uri_entry));
content_box.add (new CloneEntry (_("Location"), folder_chooser_button));
content_box.add (new CloneEntry (_("Name of Clone"), local_project_name_entry));

var cloning_label = new Granite.HeaderLabel (_("Cloning in progress"));
spinner = new Gtk.Spinner ();

var cloning_box = new Gtk.Box (HORIZONTAL, 12) {
valign = CENTER,
halign = CENTER
};
var cloning_label = new Granite.HeaderLabel (_("Cloning in progress"));
spinner = new Gtk.Spinner ();
cloning_box.add (cloning_label);
cloning_box.add (spinner);

Expand Down