-
-
Notifications
You must be signed in to change notification settings - Fork 112
Restart shell in terminal pane if it exits #1618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@lenemter I have used the existing setting object as suggested, thanks. Regarding the If you want to open the folder in the Terminal app, then you have to use the context menu - there is no shortcut. I am going to propose a PR to clarify the naming of this action. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I got confused by the action name. I thought it would open terminal pane in the directory of currently opened file, but it opens the directory of the current git project
Fixes #457
There was already code to hide the terminal if it's child exited but it had regressed and was not working.
This PR makes the terminal hide again if the shell exits.
It also restarts the shell at the last saved location and clears the screen ready for it to be used again. To enable this, the shell location is saved to settings every time it changes through app action instead of just at closing the app. (NOTE: Change of location through the shell
cdcommand is not detected so not saved)