Skip to content

Conversation

@jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Jun 29, 2025

Fixes #457

There was already code to hide the terminal if it's child exited but it had regressed and was not working.

This PR makes the terminal hide again if the shell exits.

It also restarts the shell at the last saved location and clears the screen ready for it to be used again. To enable this, the shell location is saved to settings every time it changes through app action instead of just at closing the app. (NOTE: Change of location through the shell cd command is not detected so not saved)

@jeremypw jeremypw marked this pull request as ready for review July 19, 2025 15:34
@jeremypw jeremypw requested a review from a team July 19, 2025 15:34
@jeremypw jeremypw mentioned this pull request Jul 19, 2025
2 tasks
@jeremypw jeremypw added this to the 8.1 milestone Jul 19, 2025
@jeremypw jeremypw modified the milestones: 8.1, 8.2 Jul 23, 2025
@jeremypw
Copy link
Collaborator Author

@lenemter I have used the existing setting object as suggested, thanks. Regarding the open-in-terminal action, it does seem to be working. When the shortcut is used it navigates the terminal pane to the current project build path but when used with the "Open in Terminal Pane" option in the sidebar folder context menu it navigates to the actual folder specified. Not sure why there is this difference, but that is outside the scope of this PR.

If you want to open the folder in the Terminal app, then you have to use the context menu - there is no shortcut.

I am going to propose a PR to clarify the naming of this action.

@jeremypw jeremypw requested a review from lenemter August 10, 2025 12:53
Copy link
Member

@lenemter lenemter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I got confused by the action name. I thought it would open terminal pane in the directory of currently opened file, but it opens the directory of the current git project

@lenemter lenemter merged commit 0dde465 into master Aug 10, 2025
6 checks passed
@lenemter lenemter deleted the jeremypw/terminal/close-restart-after-exit branch August 10, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exiting process running in terminal leaves terminal useless

5 participants