Skip to content

No tooltip and not selectable if dummy row #1621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremypw merged 3 commits into from
Jul 10, 2025
Merged

No tooltip and not selectable if dummy row #1621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
70ab87d
No tooltip and not selectable if dummy row
jeremypw Jun 30, 2025
3040cfe
Merge branch 'master' into jeremypw/no-blank-tooltip
jeremypw Jul 9, 2025
78273b3
Merge branch 'master' into jeremypw/no-blank-tooltip
jeremypw Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/FolderManager/FolderItem.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ namespace Scratch.FolderManager {

dummy = new Code.Widgets.SourceList.Item ("");
// Must add dummy on unexpanded folders else expander will not show
dummy.selectable = false;
((Code.Widgets.SourceList.ExpandableItem)this).add (dummy);
has_dummy = true;

Expand Down
9 changes: 6 additions & 3 deletions src/Widgets/SourceList/SourceList.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1891,8 +1891,10 @@ public class SourceList : Gtk.ScrolledWindow {
set_tooltip_row (tooltip, path);

if (item.tooltip == null) {
tooltip.set_markup (item.name);
should_show = true;
if (item.name != "") {
tooltip.set_markup (item.name);
should_show = true;
}
} else if (item.tooltip != "") {
tooltip.set_markup (item.tooltip);
should_show = true;
Expand Down Expand Up @@ -2019,8 +2021,9 @@ public class SourceList : Gtk.ScrolledWindow {

if (item != null) {
// Main categories ARE NOT selectable, so check for that
if (!data_model.is_category (item, null, path))
if (!data_model.is_category (item, null, path)) {
selectable = item.selectable;
}
}

return selectable;
Expand Down