-
-
Notifications
You must be signed in to change notification settings - Fork 113
ChooseProjectButton: fix shortcut for Open Folder #1626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
5fa129c
e70384f
3e9e348
af536bd
f23376f
5372bdd
5ada975
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,7 +12,18 @@ public class Code.PopoverMenuItem : Gtk.Button { | |
| /** | ||
| * The icon name for the button | ||
| */ | ||
| public string icon_name { get; set; } | ||
| private Gtk.Image gtk_image; | ||
| public string icon_name { | ||
| set { | ||
| gtk_image.icon_name = value; | ||
| } | ||
| } | ||
| private Granite.AccelLabel accel_label; | ||
| public string accel_string { | ||
| set { | ||
| accel_label.accel_string = value; | ||
| } | ||
| } | ||
|
|
||
| public PopoverMenuItem (string text) { | ||
| Object (text: text); | ||
|
|
@@ -23,13 +34,12 @@ public class Code.PopoverMenuItem : Gtk.Button { | |
| } | ||
|
|
||
| construct { | ||
| var image = new Gtk.Image (); | ||
|
|
||
| var label = new Granite.AccelLabel (text); | ||
| gtk_image = new Gtk.Image (); | ||
| accel_label = new Granite.AccelLabel (text); | ||
|
|
||
| var box = new Gtk.Box (HORIZONTAL, 6); | ||
| box.add (image); | ||
| box.add (label); | ||
| box.add (gtk_image); | ||
| box.add (accel_label); | ||
|
|
||
| child = box; | ||
|
|
||
|
|
@@ -41,8 +51,5 @@ public class Code.PopoverMenuItem : Gtk.Button { | |
| popover.popdown (); | ||
| } | ||
| }); | ||
|
|
||
| bind_property ("action-name", label, "action-name"); | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Instead of removing this we should probably add an action_target property to accel label
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Probably, but Code is still using the Gtk3 Granite library - is this still being developed? |
||
| bind_property ("icon-name", image, "icon-name"); | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a workaround for a bug in accel label. We should probably fix the bug instead