ShadowEffect: Delay cache drop for switching shadow sizes performance improvements #2061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenemter
reviewed
Oct 13, 2024
| } | ||
|
|
||
| private static void queue_shadow_drop (string key) { | ||
| shadows_marked_for_dropping[key] = Timeout.add_seconds (5, () => { |
There was a problem hiding this comment.
Suggested change
| shadows_marked_for_dropping[key] = Timeout.add_seconds (5, () => { | |
| shadows_marked_for_dropping[key] = Timeout.add_seconds_once (5, () => { |
There was a problem hiding this comment.
The *_once functions unfortunately do not get the data refd by vala (because they have no destroy notify) and since vala unrefs it and it's also not used anywhere else, it gets immediately freed. This causes a crash when the timeout runs.
leolost2605
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2060
Idk if this is a good and/or common way to do this but it should work 🤷
The reasoning here is that during the workspace switch animation the actor width and/or height often changes by one pixel back and forth. This would cause the shadow to be dropped and created again multiple times during a switch. By keeping them in the cache for 5 seconds before dropping them we can avoid this. While a second or so would be enough for a single switch the whole feel is a lot smoother when trying to switch over multiple workspaces in one go.