Skip to content

SearchResultItem: provide better description labels #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
danirabbit wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

SearchResultItem: provide better description labels #148

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cdbd9b6
SearchResultItem: provide better description labels
danirabbit Jul 14, 2025
636913d
Try to make more legible
danirabbit Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions src/SearchResultItem.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,28 @@ public class Maps.SearchResultItem : Granite.Bin {
set {
_place = value;

image.gicon = place.icon;
name_label.label = place.name;

if (place.street_address != null && place.town != null) {
///TRANSLATORS: a street address, followed by a town or city
info_label.label = _("%s, %s").printf (place.street_address, place.town);

return;
}

if (place.place_type == TOWN && place.state != null && place.country != null) {
///TRANSLATORS: a state or probince, followed by a country
info_label.label = _("%s, %s").printf (place.state, place.country);

return;
}

var street = place.street ?? unknown_text;
var postal_code = place.postal_code ?? unknown_text;
var town = place.town ?? unknown_text;

image.gicon = place.icon;
name_label.label = place.name;
info_label.label = "%s, %s, %s".printf (street, postal_code, town);
info_label.label = "%s, %s, %s, %s".printf (street, postal_code, town, place.state);
}
}

Expand Down