Skip to content

MainWindow: set search placeholder as spinner when loading #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
danirabbit wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

MainWindow: set search placeholder as spinner when loading #156

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 27 additions & 25 deletions src/MainWindow.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,13 @@ public class Maps.MainWindow : Adw.ApplicationWindow {
private ListStore location_store;
private Cancellable? search_cancellable = null;

private Granite.Placeholder search_placeholder;
private Gtk.Button current_location;
private Gtk.ScrolledWindow search_res_list_scrolled;
private Gtk.Spinner search_spinner;
private Gtk.Spinner spinner;
private Gtk.SearchEntry search_entry;
private Gtk.Stack search_stack;
private Gtk.Popover search_res_popover;
private MapWidget map_widget;

Expand All @@ -53,12 +57,13 @@ public class Maps.MainWindow : Adw.ApplicationWindow {
child = search_entry
};

var search_placeholder = new Adw.StatusPage () {
title = _("No Results Found"),
search_placeholder = new Granite.Placeholder (_("No Results Found")) {
description = _("Try a different search"),
icon_name = "edit-find-symbolic",
margin_start = 12,
margin_end = 12
icon = new ThemedIcon ("edit-find-symbolic")
};

search_spinner = new Gtk.Spinner () {
valign = CENTER
};

var list_factory = new Gtk.SignalListItemFactory ();
Expand All @@ -72,18 +77,20 @@ public class Maps.MainWindow : Adw.ApplicationWindow {
};
search_listview.add_css_class (Granite.STYLE_CLASS_RICH_LIST);

var search_res_list_scrolled = new Gtk.ScrolledWindow () {
search_res_list_scrolled = new Gtk.ScrolledWindow () {
child = search_listview,
hscrollbar_policy = Gtk.PolicyType.NEVER,
max_content_height = 500,
propagate_natural_height = true
};

var search_stack = new Gtk.Stack () {
search_stack = new Gtk.Stack () {
height_request = 100,
vhomogeneous = false
};
search_stack.add_child (search_res_list_scrolled);
search_stack.add_child (search_placeholder);
search_stack.add_child (search_spinner);

search_res_popover = new Gtk.Popover () {
width_request = 400,
Expand Down Expand Up @@ -152,14 +159,6 @@ public class Maps.MainWindow : Adw.ApplicationWindow {
map_widget.go_to_current ();
});

selection_model.items_changed.connect (() => {
if (selection_model.get_n_items () == 0) {
search_stack.visible_child = search_placeholder;
} else {
search_stack.visible_child = search_res_list_scrolled;
}
});

var search_key_controller = new Gtk.EventControllerKey ();
search_key_controller.key_pressed.connect ((keyval, keycode, state) => {
switch (keyval) {
Expand Down Expand Up @@ -212,15 +211,16 @@ public class Maps.MainWindow : Adw.ApplicationWindow {
}

private void busy_start (BusyReason new_reason) {
// Not busy → Busy
if (!(bool)(current_busy_reason & BusyReason.ANY)) {
spinner.visible = true;
spinner.spinning = true;
}

// Not locating → Locating
if ((bool)(new_reason & BusyReason.LOCATING)) {
current_location.sensitive = false;
spinner.spinning = true;
}

// Not Searching → Searching
if ((bool)(new_reason & BusyReason.SEARCHING)) {
search_spinner.spinning = true;
search_stack.visible_child = search_spinner;
}

current_busy_reason |= new_reason;
Expand All @@ -232,12 +232,12 @@ public class Maps.MainWindow : Adw.ApplicationWindow {
// Locating → Not locating
if ((bool)(new_reason & BusyReason.LOCATING)) {
current_location.sensitive = true;
spinner.spinning = false;
}

// Busy → Not busy
if (!(bool)(current_busy_reason & BusyReason.ANY)) {
spinner.visible = false;
spinner.spinning = false;
// Searching → Not locating
if (!(bool)(new_reason & BusyReason.SEARCHING)) {
search_spinner.spinning = false;
}
}

Expand Down Expand Up @@ -280,8 +280,10 @@ public class Maps.MainWindow : Adw.ApplicationWindow {
var places = new List<Geocode.Place> ();
try {
places = yield forward.search_async (search_cancellable);
search_stack.visible_child = search_res_list_scrolled;
} catch (Error error) {
warning (error.message);
search_stack.visible_child = search_placeholder;
return;
}

Expand Down