fix(mcp): require calendarName and surface 404 as actionable error#90
Merged
fix(mcp): require calendarName and surface 404 as actionable error#90
Conversation
- Remove hardcoded 'personal' default from calendarName across all five calendar tools — the default was wrong for many Nextcloud installations - Throw a clear error in assertCalendarSupportsEvents on HTTP 404 so the AI knows to call list_calendars instead of getting a raw Sabre XML response - Update calendarName descriptions to hint at list_calendars Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
'personal'default fromcalendarNameacross all five calendar tools — this default was incorrect for Nextcloud installations that use a different calendar nameassertCalendarSupportsEventsas a clear, actionable error message instead of letting it fall through to a raw Sabre XML responsecalendarNamedescriptions in all tools to hint atlist_calendarsTest plan
create_event,list_events, etc.) with a non-existent calendar name → expect error:Calendar "X" not found. Use list_calendars to find available calendar names.calendarNameis now required (no default) in all five calendar toolsnpm test,npm run lint,npx prettier --check src/all pass🤖 Generated with Claude Code