Address PR #15 review findings across config/start/nuke and TUI paste/scroll behavior#16
Merged
Merged
Conversation
- new-user branch routes to setup
- existing-user branch shows snapshot (budget/phases/deferred)
with continue/sweep/new-plan paths
- new-plan flow drives in-TUI interview + planner agent
(questioner_ranged.txt template), shows generated phase list
with run/wait/terminate choices
"
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
…andling Agent-Logs-Url: https://github.com/elicpeter/pitboss/sessions/0305b422-6afe-4025-892b-676ea6f451b6 Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code according to review comments
Address PR #15 review findings across config/start/nuke and TUI paste/scroll behavior
May 24, 2026
Owner
|
@copilot fix rustdoc failing ci |
Owner
|
@copilot fix rustdoc failing ci |
Agent-Logs-Url: https://github.com/elicpeter/pitboss/sessions/2348e334-ea63-4afb-9c9d-9ffd24df46db Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Contributor
Author
Fixed in 30cd987. I removed the private intra-doc link in
Addressed in 30cd987. The rustdoc failure was from a private intra-doc link in |
| Ev::Continue | ||
| } | ||
| KeyCode::Char(c) => { | ||
| s.test_input.push(c); |
Comment on lines
+6
to
+16
| //! and, if the user opted into AI plan generation, chains into | ||
| //! `pitboss play --tui`. End-to-end install → configure → plan → play in | ||
| //! one command. | ||
| //! - **Present:** runs the iteration wizard ([`crate::tui::iteration`]) which | ||
| //! shows a snapshot of the current run (budget used, phase progress, | ||
| //! deferred items) and offers continue / sweep / new-plan paths, each with | ||
| //! an optional reset-budget toggle. | ||
| //! | ||
| //! This command is purely additive: it composes existing pitboss commands | ||
| //! (`setup`, `plan`, `play`, `rebuy`, `sweep`). It does not change their | ||
| //! behavior or schemas. |
Comment on lines
+196
to
+198
| super::sweep::run(workspace, default_sweep_args()) | ||
| .await | ||
| .map(|_| ()) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the areas called out in the review thread: wizard paste input handling, sweep threshold validity,
nukeconfirmation semantics,starthelp text accuracy, and multiline scroll math in iteration inputs. The goal is to align user-visible behavior and generated config with current runtime expectations.Wizard: handle bracketed paste events
CtEvent::Pastehandling insrc/tui/wizard.rs.Config writer: prevent invalid
trigger_min_items = 0src/cli/config.rs,sweep_thresholdis clamped to>= 1before writingtrigger_min_items.Some(0).nukeconfirmation: align behavior with documented semanticssrc/cli/nuke.rs, confirmation now accepts any input starting withy/Y(after trim/lowercase), matching the function contract.startcommand help text: align docs with actual flowsrc/cli/mod.rs, updatedStartcommand description to reflect real behavior for missing.pitboss/(run setup + print next steps; no automaticplay --tuichaining).Iteration TUI: multiline-aware visual scroll/cursor math
src/tui/iteration.rs, replaced single-line char-count assumptions with newline-aware visual line calculations.\nplus wrapping when input contains multiline paste content.