-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fallback to FileReader in iOS Chrome #612
base: master
Are you sure you want to change the base?
Conversation
…fixes the bug in Chrome iOS 13 when the file opens in same window.
…. This probably fixes the bug in Chrome iOS 13 when the file opens in same window.
I'm seeing the same issue. My use case is downloading short videos. On iOS these are quicktime / mov videos. In Safari 13 they download great using I spiked on testing the FileReader approach in Chrome for iOS. I was able to have it trigger a download in the browser but the file type wasn't present and the file name wasn't present. It was just called "download". Then it would let me navigate to the iPhone file system but the "Save" button was disabled so I was unable to persist the file. @eligrey if @evgeniy-polyakov is able to fix the merge conflicts here, would you accept this PR? thanks all |
Fantastic work @evgeniy-polyakov, however in ios Chrome, it opens a new tab that defaults to a "document" file name. Is there some way to use a custom filename? |
# Conflicts: # dist/FileSaver.js # dist/FileSaver.min.js # dist/FileSaver.min.js.map # src/FileSaver.js
I don't have immediate access to an iOS device. I'll test & merge this sometime next week 👍 |
It seems to be already fixed in the original repository for all iOS browsers, not only Chrome. You use 'AppleWebKit' to test User Agent instead of 'CriOS': I'm declining the pull request, no useful fixes here. |
I'm reopening the pull request. |
I believe this issue is still present in iOS 14 with Chrome v87. |
iOS 13 introduces "download" attribute but it behaves incorrectly in Chrome - the file is always open in same window. This pull request forces to use FileReader in iOS Chrome.
Also merged #578