Better docs for Repos that use Ecto.Adapters.SQL.Adapter
#671
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functions added by
Ecto.Adapters.SQL.Adapter.__before_compile__
into Repos have some sparse documentation telling the user to go look elsewhere to the underlying function; this makes it harder for folks using LSPs and and their cursor is onMyApp.query(...)
to get any helpful documentation, instead requiring them to either open docs outside of their editor, or have a temporary line pointing toEcto.Adapters.SQL.query(...)
and get the docs, and then set back toMyApp.query(...)
I also switched the examples to mention the more-likely function included in the user's
MyRepo
first instead ofEcto.Adapters.SQL
. Some of the examples where usingRepo
and othersMyRepo
-- I changed toMyRepo
because that seemed clearer to me.Before
iex(1)> h Foo.Repo.query def query(sql, params \\ [], opts \\ []) A convenience function for SQL-based repositories that executes the given query. See Ecto.Adapters.SQL.query/4 for more information.
After
full outputs