-
Notifications
You must be signed in to change notification settings - Fork 3.4k
docs: enhance non-assertive map access anti-pattern documentation #14501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: enhance non-assertive map access anti-pattern documentation #14501
Conversation
abreujp
commented
May 17, 2025
- Add comparison table for access notations
- Improve explanations with clearer examples
- Add example of error propagation
- Include guidance for when to use each access method
- Format examples for better readability
- Add comparison table for access notations - Improve explanations with clearer examples - Add example of error propagation - Include guidance for when to use each access method - Format examples for better readability
- Add "Map is `nil`" column to map access table - Include Map.get and Map.fetch! access methods - Combine error propagation examples - Add summary section on pattern-matching
Thank you @sabiwara for your valuable feedback! I've updated the pull request with all your suggested changes:
I'm new to open source contributions and still learning the best practices, so I truly appreciate your detailed review. Your guidance helps me improve both the documentation and my understanding of how to contribute effectively. Let me know if you'd like any further adjustments! |
Thank you @abreujp! I have submitted some changes to remove the duplication and streamline it. If you are happy with it, let me know and I will merge it! |
Yes, I agree, thank you. @josevalim |
💚 💙 💜 💛 ❤️ |