docs: enhance non-assertive map access anti-pattern documentation#14501
Merged
josevalim merged 6 commits intoelixir-lang:mainfrom May 20, 2025
Merged
Conversation
Contributor
abreujp
commented
May 17, 2025
- Add comparison table for access notations
- Improve explanations with clearer examples
- Add example of error propagation
- Include guidance for when to use each access method
- Format examples for better readability
- Add comparison table for access notations - Improve explanations with clearer examples - Add example of error propagation - Include guidance for when to use each access method - Format examples for better readability
sabiwara
reviewed
May 19, 2025
sabiwara
reviewed
May 19, 2025
- Add "Map is `nil`" column to map access table - Include Map.get and Map.fetch! access methods - Combine error propagation examples - Add summary section on pattern-matching
Contributor
Author
|
Thank you @sabiwara for your valuable feedback! I've updated the pull request with all your suggested changes:
I'm new to open source contributions and still learning the best practices, so I truly appreciate your detailed review. Your guidance helps me improve both the documentation and my understanding of how to contribute effectively. Let me know if you'd like any further adjustments! |
josevalim
reviewed
May 20, 2025
Member
|
Thank you @abreujp! I have submitted some changes to remove the duplication and streamline it. If you are happy with it, let me know and I will merge it! |
Contributor
Author
|
Yes, I agree, thank you. @josevalim |
josevalim
reviewed
May 20, 2025
josevalim
reviewed
May 20, 2025
Member
|
💚 💙 💜 💛 ❤️ |
Nezteb
pushed a commit
to Nezteb/elixir
that referenced
this pull request
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.