Skip to content

Improve :file info type in stacktrace entries - #15892

Open
lukaszsamson wants to merge 3 commits into
elixir-lang:mainfrom
lukaszsamson:ls-stacktrace-type-improve
Open

lukaszsamson wants to merge 3 commits into
elixir-lang:mainfrom
lukaszsamson:ls-stacktrace-type-improve

Conversation

@lukaszsamson

Copy link
Copy Markdown
Contributor

This PR further improves type of file info in stacktrace by allowing nested chardata
Follow up to #15798

AssistedBy: Claude Fable 5.1

Comment thread lib/elixir/lib/module/types/apply.ex Resolved
@lukaszsamson

Copy link
Copy Markdown
Contributor Author

@josevalim recursive types would spin endlessly on to_quoted. I added a clause handling that. I also added scope param to recursive. Previously used make_ref() would not work with macro escaped signatures

@josevalim

Copy link
Copy Markdown
Member

Oh, I suppose we need to add pretty printing of recursive types first.

Introduce scoped recursive nodes that can be embedded in compiled signatures. Use the recursive pretty printer and recognize scoped node IDs when selecting it.

Assisted-by: Codex:GPT-6
@lukaszsamson
lukaszsamson force-pushed the ls-stacktrace-type-improve branch from e4c89e7 to 6d47e11 Compare November 7, 2026 18:17
@lukaszsamson

Copy link
Copy Markdown
Contributor Author

@josevalim recursive type printing landed on main. I rebased this PR

@josevalim
josevalim requested a review from gldubc November 8, 2026 16:07
@josevalim

Copy link
Copy Markdown
Member

PS: move chardata to the Of module.

@lukaszsamson

Copy link
Copy Markdown
Contributor Author

PS: move chardata to the Of module.

Done

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants