Repository navigation
Do not fold URI parsing calls at compile time - #16087
Merged
josevalim merged 1 commit intoNov 9, 2026
Merged
Conversation
URI.parse/1, URI.new/1, and URI.new!/1 consult the mutable default-port table, including for built-in schemes. Keep literal calls at runtime so they observe ports registered after compilation. Assisted-by: Codex:GPT-6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
URI.parse/1,URI.new/1, andURI.new!/1consult the globally mutable default-port table when an input has no explicit port. Folding literal calls at compile time freezes the port before an application's start callback can register or override it. This PR removes the three functions frominline_pure_function/2so literal calls observe the runtime configuration, just like calls with dynamic inputs.Assisted-by: Codex:GPT-6