Account for buffered events in dispatchers#312
Closed
stefanc18 wants to merge 1 commit intoelixir-lang:mainfrom
Closed
Account for buffered events in dispatchers#312stefanc18 wants to merge 1 commit intoelixir-lang:mainfrom
stefanc18 wants to merge 1 commit intoelixir-lang:mainfrom
Conversation
josevalim
reviewed
Jun 22, 2025
| dispatcher_callback(:ask, [counter, from, dispatcher_state], stage) | ||
| %{dispatcher_state: dispatcher_state, buffer: buffer} = stage | ||
| buffer_size = Buffer.estimate_size(buffer) | ||
| dispatcher_callback(:ask, [counter, buffer_size, from, dispatcher_state], stage) |
Member
There was a problem hiding this comment.
I wonder if instead we should subtract the buffer size from the counter and only ask if the counter is more than zero?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated the demand & partition dispatchers to account for the buffered events by adding an additional
buffer_sizeparameter to theaskfunction. Therefore, if there are events in the buffer, they will be asked for. This solves the issue that happens when the producer buffers some events (because there are no consumers available), and then the consumers come back live. Previously the buffered events weren't sent because they were considered "already sent". Refer to the issue for the details of how the behavior reproduced: #311